Fix failing tests due to Mustache dependency conflict#280
Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
github-actions
bot
added
bug
dependencies
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the default and tested minimum WP-CLI version from Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the required WP-CLI version from ^2.12 to ^2.13 to resolve a dependency conflict. The changes are applied consistently across the command's default value and the corresponding test files. My review includes one suggestion to improve the maintainability of the test suite by reducing the duplication of the version string in test files.
There was a problem hiding this comment.
Pull request overview
Updates the default WP-CLI version constraint used by wp scaffold package to avoid dependency conflicts (notably around transitive dependencies like Mustache) and aligns the acceptance tests with the new default.
Changes:
- Bump
--require_wp_clidefault from^2.12to^2.13. - Update Behat feature expectations for scaffolded
composer.jsonand generated README text to reflect the new minimum. - Keep scaffold/readme behaviors consistent by aligning tests for both package scaffolding and README scaffolding.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ScaffoldPackageCommand.php | Updates the documented default for --require_wp_cli to ^2.13. |
| features/scaffold-package.feature | Updates expected scaffolded composer.json WP-CLI requirement to ^2.13. |
| features/scaffold-package-readme.feature | Updates expected README/install text and embedded composer snippets to reference WP-CLI v2.13 / ^2.13. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
No description provided.